Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] discovery.HostNode() should accept configs rather than read env directly #300

Closed
qazwsxedckll opened this issue Apr 19, 2024 · 1 comment · Fixed by #314
Closed

Comments

@qazwsxedckll
Copy link
Collaborator

Reading and merging env to configs should be handled by user using some modules like viper or koanf.

To my opinion, I always avoid using env and put all configs in local config files. I have come accross many times that a mysterious env is controlling a key feature and no one knows about it. It is a nightmare to debug.

@Tochemey
Copy link
Owner

Thanks for the suggestion. I will look into it. However there are no hidden env vars and there are all documented only few used for cluster run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants