chips/qemu_rv32_virt_chip: implement basic UART RX and add process console to board #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twilfredo
previously approved these changes
Jan 2, 2023
hudson-ayers
previously approved these changes
Jan 3, 2023
alistair23
previously approved these changes
Jan 12, 2023
|
bors r+ |
|
Merge conflict. |
lschuermann
dismissed stale reviews from alistair23, hudson-ayers, and twilfredo
via
2deddd0
lschuermann
force-pushed
the
dev/qemu-rv32-virt-pconsole
branch
from
371b507
to
2deddd0
Compare
|
Rebased accordingly, merging if checks succeed. bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 8, 2023
3365: chips/qemu_rv32_virt_chip: implement basic UART RX and add process console to board r=lschuermann a=lschuermann ### Pull Request Overview Implements basic UART RX support (without abort) and adds the process console component to the board. I didn't want to invest time in supporting receive-abort, as this needs to be migrated to the new UART HIL anyways (#3046). ### Testing Strategy This pull request was tested by using the process console. ### TODO or Help Wanted N/A ### Documentation Updated - [x] ~Updated the relevant files in `/docs`,~ or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Leon Schuermann <leon@is.currently.online>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"At least 1 approving review is required by reviewers with write access. Required status check \"netlify/docs-tockosorg/deploy-preview\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors bot
added a commit
that referenced
this pull request
Feb 8, 2023
3365: chips/qemu_rv32_virt_chip: implement basic UART RX and add process console to board r=hudson-ayers a=lschuermann ### Pull Request Overview Implements basic UART RX support (without abort) and adds the process console component to the board. I didn't want to invest time in supporting receive-abort, as this needs to be migrated to the new UART HIL anyways (#3046). ### Testing Strategy This pull request was tested by using the process console. ### TODO or Help Wanted N/A ### Documentation Updated - [x] ~Updated the relevant files in `/docs`,~ or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Leon Schuermann <leon@is.currently.online>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: Response status code: 422
{"message":"Required status check \"netlify/docs-tockosorg/deploy-preview\" is failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
alistair23
previously approved these changes
Feb 8, 2023
lschuermann
dismissed stale reviews from alistair23 and hudson-ayers
via
34e038a
lschuermann
force-pushed
the
dev/qemu-rv32-virt-pconsole
branch
from
2deddd0
to
34e038a
Compare
|
@hudson-ayers Could you give another approval perhaps? This time the Netlify CI didn't glitch out, so maybe fourth time's the charm? 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
Implements basic UART RX support (without abort) and adds the process console component to the board. I didn't want to invest time in supporting receive-abort, as this needs to be migrated to the new UART HIL anyways (#3046).
Testing Strategy
This pull request was tested by using the process console.
TODO or Help Wanted
N/A
Documentation Updated
Updated the relevant files inor no updates are required./docs,Formatting
make prepush.