kernel: debug: update #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove header, file, and line number information from `debug!()`. This helps with overflowing debug messages where any sort of tight loop causes the kernel to crash when the debug! buffer fills up. - Move existing debug behavior to a new macro called `debug_verbose!()`. - Simplify code by removing redundant begin_debug function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request changes the kernel debug macro in the following ways:
debug!(). This helps with overflowing debug messages where any sort of tight loop causes the kernel to crash when the debug! buffer fills up.debug_verbose!().Testing Strategy
This pull request was tested by adding some debug! prints to the hail/main.rs file and verifying that they still print.
Documentation Updated
/docshave been updated or no updates are required.Are we intending to keep those courses up to date? That is going to be a lot of work.
Formatting
make formatallhas been run.