Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Typescript specifc remarks / info? #69

Closed
AkosLukacs opened this issue Jun 20, 2016 · 4 comments
Closed

[Question] Typescript specifc remarks / info? #69

AkosLukacs opened this issue Jun 20, 2016 · 4 comments

Comments

@AkosLukacs
Copy link

Hey Todd,
What would be your opinion about including some typescript related info into you guide?
If PRs are welcome, should those be included as a new chapter, or inline? I guess a new chapter would be less disturbing overall, but easier to miss...

@mcranston18
Copy link

Though this might be beyond the scope of the question, I'd be curious to hear thoughts on whether TypeScript is even integral to good Angular 1.5/2 code. This style guide obviously doesn't use TS so does that mean it recommends not using it if a dev is about to start a new Angular project?

@toddmotto
Copy link
Owner

toddmotto commented Jun 21, 2016

@AkosLukacs Hey! So, I think a TypeScript version would be extremely awesome. What do you think to the following directory structure:

readme.md (main readme - points to the other guides giving user the choice)

es2015/
      readme.md
  i18n/
      es-es.md

typscript/
      readme.md
  i18n/
      es-es.md

The readme.md would simply point to the other guides, which inside contain the relevant i18n folders for each guide's translation.

@mcranston18 It's not included in the guide because I don't feel it's up to me to decide whether you/your team should use TypeScript (similarly with Angular 2, however it may be advised for Angular 2).

@floriangosse
Copy link
Contributor

@AkosLukacs @toddmotto maybe the styleguide of Airbnb is an inspiration: https://github.com/airbnb/javascript

@toddmotto
Copy link
Owner

Closing this one as @laskoviymishka has made a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants