Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Readonly or on Readonly::Array? #127

Closed
andk opened this issue Jul 10, 2018 · 1 comment
Closed

Dependency on Readonly or on Readonly::Array? #127

andk opened this issue Jul 10, 2018 · 1 comment

Comments

@andk
Copy link

andk commented Jul 10, 2018

Executive summary: Please drop the dependencies on Readonly::Array and Readonly.

TLDR:

Grepping through all *.pm files does not confirm that there is a dependency.

Readonly is used in t/readonly.t but the test gets skipped if the 'use Readonly' does not succeed.

Readonly::Array is a package within the file Readonly.pm, so it does not ever exist in a file Readonly/Array.pm.

Readonly::Array is indexed on the CPAN but older vorsions of the CPAN client complain that Readonly::Array could not be loaded.

Bottom line: a not-dependency forces all users to install Readonly without need. Additionally, older software may have issues with the dependency Readonly::Array.

@mohawk2
Copy link
Collaborator

mohawk2 commented Jul 10, 2018

Sounds like Readonly::Array should be dropped, and Readonly switched to a recommends?

@toddr toddr closed this as completed in 95402aa Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants