Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t/run.t to work on "perl in space" #100

Merged
merged 1 commit into from Mar 18, 2018
Merged

Fix t/run.t to work on "perl in space" #100

merged 1 commit into from Mar 18, 2018

Conversation

mohawk2
Copy link
Collaborator

@mohawk2 mohawk2 commented Mar 18, 2018

No description provided.

@toddr
Copy link
Member

toddr commented Mar 18, 2018

unless $perl is somehow an object I don't see how quotes would make a difference. Can you give me a more verbose commit message explaining the change please?

@mohawk2
Copy link
Collaborator Author

mohawk2 commented Mar 18, 2018

This isn't to stringify; it's to add double-quotes so the shell doesn't treat a $perl which has a string in it as several "words", but one.

@toddr
Copy link
Member

toddr commented Mar 18, 2018

makes sense. Can you update the commit message so year from now me knows what this was about?

Add `""` around the command name makes the shell treat a `$perl` with
spaces as a single word rather than splitting on those spaces.
@toddr toddr merged commit f2ec2c2 into cpan-authors:master Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants