Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inc/Devel/CheckLib.pm from 0.99 to 1.14 #89

Merged
merged 3 commits into from Dec 28, 2023

Conversation

tzccinct
Copy link

@tzccinct tzccinct commented Apr 7, 2021

This is a pull request for #86. For reference, "hide from PAUSE" hack, which was once done by (deprecated) use-devel-checklib script, is unnecessary for inc/ directory.

@tzccinct tzccinct changed the title Update inc/Devel/CheckLib.pm from 0.99 to 1.14. Update inc/Devel/CheckLib.pm from 0.99 to 1.14 Apr 7, 2021
@tzccinct
Copy link
Author

tzccinct commented Apr 8, 2021

Even after reverting inc/Devel/CheckLib.pm from 1.14 to 0.99 (and only fixing the outdated .github/workflows/windows.yml), the CI error for windows goes on. The CI error log says it was unable to find expat library by inc/Devel/CheckLib.pm, but Strawberry Perl installs expat by default. I have tested this on my Strawberry Perl environment, but I am unable to reproduce this issue.

@glensc
Copy link

glensc commented May 28, 2023

formatting changes should be excluded, and probably submitted as standalone pr's and other fixes (github path thing). they have a chance of getting merged imho.

@tzccinct
Copy link
Author

If I remember correctly, I created the standalone PR without formatting changes at first but the CI error occurred. So I added the formatting changes to try to fix it, but in vain. I have no idea why the CI in Windows platform failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants