Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lib Refactoring - Readonly Fields #24

Closed
mblenczewski opened this issue Apr 11, 2019 · 1 comment
Closed

Lib Refactoring - Readonly Fields #24

mblenczewski opened this issue Apr 11, 2019 · 1 comment
Labels
refactor Marks an issue as a refactoring issue; it is not critical by itself.

Comments

@mblenczewski
Copy link
Contributor

A lot of the fields in many classes are not marked readonly but assigned at instantiation and never touched again. An example would be Connection.requestResponseMap. Here it should never be reassigned (we would lose all registered response packets). Thus it should be clearly marked as such, with the 'readonly' keyword. In fact, all similar fields should also be marked with 'readonly'.
@mblenczewski mblenczewski added the refactor Marks an issue as a refactoring issue; it is not critical by itself. label Apr 11, 2019
@Toemsel
Copy link
Owner

Toemsel commented Apr 15, 2019

Agree. Please fix and create PR

@Toemsel Toemsel closed this as completed Apr 15, 2019
@Toemsel Toemsel reopened this Apr 15, 2019
@Toemsel Toemsel closed this as completed Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Marks an issue as a refactoring issue; it is not critical by itself.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Toemsel @mblenczewski