Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): unable to create blank lines correctly #7032

Merged
merged 1 commit into from
May 27, 2024

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 22, 2024

Close #7022

Copy link

graphite-app bot commented May 22, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

JimmFly commented May 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JimmFly and the rest of your teammates on Graphite Graphite

@JimmFly JimmFly marked this pull request as ready for review May 22, 2024 10:16
@JimmFly JimmFly requested review from pengx17 and EYHN May 22, 2024 10:17
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.03%. Comparing base (8ed0ceb) to head (2d2a849).

Additional details and impacted files
@@           Coverage Diff           @@
##           canary    #7032   +/-   ##
=======================================
  Coverage   67.03%   67.03%           
=======================================
  Files         585      585           
  Lines       28885    28885           
  Branches     2608     2608           
=======================================
  Hits        19362    19362           
  Misses       9252     9252           
  Partials      271      271           
Flag Coverage Δ
server-test 77.45% <ø> (ø)
unittest 39.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented May 27, 2024

Merge activity

  • May 27, 12:39 AM EDT: EYHN added this pull request to the Graphite merge queue.
  • May 27, 12:55 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'Server E2E Test 1/3').
  • May 27, 3:39 AM EDT: EYHN added this pull request to the Graphite merge queue.
  • May 27, 3:51 AM EDT: EYHN merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot merged commit 2d2a849 into canary May 27, 2024
32 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0522/fix-gap branch May 27, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Mouse pointer can only create a new line in a specific area of the document
2 participants