Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edgeless selection rect doesn’t follow undo/redo #1250

Closed
doodlewind opened this issue Feb 16, 2023 · 8 comments · Fixed by #3693
Closed

Edgeless selection rect doesn’t follow undo/redo #1250

doodlewind opened this issue Feb 16, 2023 · 8 comments · Fixed by #3693
Labels
mod:edgeless Module: related to edgeless mode roadmap Overall schedules and plannings type:bug Something isn't working
Milestone

Comments

@doodlewind
Copy link
Member

doodlewind commented Feb 16, 2023

This is similar with #1249 but just triggered by performing undo/redo.

Screen.Recording.2023-03-14.at.23.33.56.mov
@doodlewind doodlewind added type:bug Something isn't working good first issue Good for newcomers help wanted mod:edgeless Module: related to edgeless mode and removed help wanted labels Feb 16, 2023
@doodlewind doodlewind added this to the AFFiNE 0.6 milestone Apr 24, 2023
@donglixiaoche
Copy link
Contributor

donglixiaoche commented May 5, 2023

@doodlewind @alt1o is there anyone working on this issue? if no, i'd love to have a try

@alt1o
Copy link
Contributor

alt1o commented May 5, 2023

@doodlewind @alt1o is there any working on this issue? if no, i'd love to have a try

That's very nice. No one is working on this issue.

@donglixiaoche
Copy link
Contributor

@doodlewind @alt1o is there any working on this issue? if no, i'd love to have a try

That's very nice. No one is working on this issue.

copy, so i'm going to work on it. leave a comment here to avoid duplicate working.

@donglixiaoche
Copy link
Contributor

donglixiaoche commented May 9, 2023

@doodlewind for this issue, assume a undo cause a selected shape object deleted, and then, if we use redo to recreate this shape object, do we need to reselect this shape object either?

@regischen
Copy link
Member

@donglixiaoche yes, need to reselect this element.
by the way, are you still working on it?

@donglixiaoche
Copy link
Contributor

donglixiaoche commented May 25, 2023

@regischen previously i dicussed with @doodlewind, seems like this issue requires more works than i thought. i thought we should make selection status works like cursor, and share them between multiple clients. i'd love to continue, but seems like we need some product design first

@donglixiaoche
Copy link
Contributor

@donglixiaoche yes, need to reselect this element. by the way, are you still working on it?

or do you think if i can help to design this feature? need some investigation, it may take some time, and also i may need some help about the architecture of this whole blocksuite project

@xell xell modified the milestones: AFFiNE 0.6, AFFiNE 0.7 Jun 5, 2023
@xell xell added the roadmap Overall schedules and plannings label Jun 5, 2023
@Flrande
Copy link
Member

Flrande commented Jul 5, 2023

This issue is waiting for the reconstruction related to selection.
cc @doodlewind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mod:edgeless Module: related to edgeless mode roadmap Overall schedules and plannings type:bug Something isn't working
Projects
Archived in project
Archived in project
6 participants