Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding database by slash menu in quote or list block inserts at incorrect position #3089

Closed
xell opened this issue Jun 13, 2023 · 3 comments · Fixed by #3102
Closed

Adding database by slash menu in quote or list block inserts at incorrect position #3089

xell opened this issue Jun 13, 2023 · 3 comments · Fixed by #3102
Assignees
@zqran
Labels
beta Issues should be fixed for current Beta release. mod:widget Related to positioned menus type:bug Something isn't working
Milestone
AFFiNE 0.7

Comments

@xell
Copy link
Contributor

xell commented Jun 13, 2023 •
edited

may need to check other block types for the same behavior.
@xell xell changed the title Bug about adding table by slash menu in a quote block Bug about adding database by slash menu in a quote block Jun 13, 2023
@xell xell added type:bug Something isn't working beta Issues should be fixed for current Beta release. labels Jun 13, 2023
@xell xell added this to the AFFiNE 0.7 milestone Jun 13, 2023
@doodlewind doodlewind added the mod:widget Related to positioned menus label Jun 13, 2023
@doodlewind doodlewind changed the title Bug about adding database by slash menu in a quote block Adding database by slash menu in quote or list block inserts at incorrect position Jun 13, 2023
@doodlewind doodlewind assigned zqran and unassigned doodlewind Jun 13, 2023
@zqran
Copy link
Sponsor Member

zqran commented Jun 14, 2023 •
edited

What should be the correct behavior?

  1. Convert the current content into a database
  2. Insert the database behind the current block (currently in front)

@doodlewind
Copy link
Member

doodlewind commented Jun 14, 2023 •
edited

What should be the correct behavior?

  1. Convert the current content into a database
  2. Insert the database behind the current block (currently in front)

Option 2 LGTM!

@zqran zqran mentioned this issue Jun 14, 2023
Merged
@xell
Copy link
Contributor Author

xell commented Jun 15, 2023

@zqran I think the redundant blank line added by slash menu action should be removed:

CleanShot.2023-06-15.at.08.20.04.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zqran zqran

Labels
beta Issues should be fixed for current Beta release. mod:widget Related to positioned menus type:bug Something isn't working
Projects
AFFiNE Project
Archived in project
BlockSuite Project
Archived in project
Milestone
AFFiNE 0.7
Development

Successfully merging a pull request may close this issue.

feat(slash-menu): insert database after the current block zqran/blocksuite
3 participants
@xell @doodlewind @zqran