Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need interop with trace4cats? #588

Open
Ssstlis opened this issue Apr 2, 2021 · 7 comments
Open

Do we need interop with trace4cats? #588

Ssstlis opened this issue Apr 2, 2021 · 7 comments

Comments

@Ssstlis
Copy link
Member

Ssstlis commented Apr 2, 2021

trace4cats lib have some context type classes and lenses right here, so when you use tofu context type classes and lenses with TF style you probably need some interop implicit conversion, which we can provide for users automatically. Can we place it inside tofu?

@catostrophe
Copy link
Member

We definitely need interop, and we already have it. But it's not published and I am not sure if the main repo is a right place for it.

@Ssstlis
Copy link
Member Author

Ssstlis commented Apr 2, 2021

What do you mean 'main repo'? trace4cats or tofu? If we already have it - how I can find it?
Maybe I misspell when write 'inside tofu', I wanna mean 'interop module' of course.

@Odomontois
Copy link
Member

Odomontois commented Apr 6, 2021

We are talking about a little bit of tidying here and moving some integrations to dedicated repos under the tofu.tf org

@Ssstlis
Copy link
Member Author

Ssstlis commented Apr 7, 2021

Ok then, how I can contribute it now? And how can foreign contributors do it?

@Odomontois
Copy link
Member

I've sent an invitation to you, you can start a new repo, private or public after acceptance

@Ssstlis
Copy link
Member Author

Ssstlis commented Apr 8, 2021

Thank you for the invitation! @Odomontois the last one question - how do we version foreign repos?

@Odomontois
Copy link
Member

Odomontois commented Apr 13, 2021

@Ssstlis Ideally a foreign repo has the same first two numbers (after zero) as the core tofu version, and then an additional number for its own updates, unrelated to the core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants