HTTPS support #27
Closed
HTTPS support #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lresende
reviewed
Mar 25, 2019
|
@lresende any success? |
dimon222
force-pushed
the
feature/optional_https
branch
from
e6b4d68
to
e7dd511
Compare
|
@lresende since my refactoring PR got merged, I recreated this branch to make it compatible. |
lresende
reviewed
May 29, 2019
| @@ -19,13 +19,15 @@ class ApplicationMaster(BaseYarnAPI): | |||
| :param int port: Proxy HTTP port | |||
| :param int timeout: API connection timeout in seconds | |||
| :param boolean kerberos_enabled: Flag identifying is Kerberos Security has been enabled for YARN | |||
| :param boolean https: Flag identifying HTTPS is used instead of HTTP for YARN | |||
| :param boolean https_verify: Flag identifying SSL certificate should be ignored in case of HTTPS | |||
There was a problem hiding this comment.
As we are forwarding this parameter all way to requests, could you please use/append similar documentation as the one available in requests: Either a boolean, in which case it controls whether we verify the server’s TLS certificate, or a string, in which case it must be a path to a CA bundle to use
|
@dimon222 Could you please rebase this as well. |
|
Closed, better approach is suggested there - #33 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #19
The only thing is - do we need to apply any corrections in hadoop_conf detection to pull HTTPS urls out as well, or no?
PS: this will conflict with #26, might require rebase incase of merge needs