-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More details for readme #53
More details for readme #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I prefer markdown over rst so I like that idea. Did you want to do that as part of this change - or wait on that? |
@kevin-bates I'll convert to markdown shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment. Everything else looks good, but we'll know more once that back-quotes are fixed.
EDIT: The build is failing because setup.py pulls the long description from README.rst.
6ce47f2
to
dd861f3
Compare
235b99f
to
53ccee3
Compare
@kevin-bates if u could provide the details on error for |
ok - I'll try to take a look. That stuff is a bit of mystery to me. |
@dimon222 - looks like @toidi is the sole maintainer. The last build was the failure nearly two years ago. I can't really see anything apparently wrong. https://readthedocs.org/projects/python-client-for-hadoop-yarn-api/builds/6260674/ Since these have been failing for some time and we need more access/information, I think we should move on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks. We'll address the 20 month-old doc build issues later.
@kevin-bates I agree. Btw, I'm able to run build from my own fork without issues. I think github token that was used for Oauth to pull repo is no longer valid. If you or @lresende could request/register on readthedocs (maybe it can inherit access permissions from anyone who has access to change repository), it might refresh that Oauth token and start generating docs correctly. The main problem is that new documentation is not being generated, so people might get confused by incompatible API signatures (since we significantly changed it since then) |
Given the docs build locally for you, I'm going ahead with the merge. Thank you! |
Fix #50
Does it make sense to also convert it to markdown? Currently still
RST