Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More details for readme #53

Merged

Conversation

dimon222
Copy link
Collaborator

Fix #50
Does it make sense to also convert it to markdown? Currently still RST

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin-bates
Copy link
Member

I prefer markdown over rst so I like that idea. Did you want to do that as part of this change - or wait on that?

@dimon222
Copy link
Collaborator Author

@kevin-bates I'll convert to markdown shortly.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment. Everything else looks good, but we'll know more once that back-quotes are fixed.

EDIT: The build is failing because setup.py pulls the long description from README.rst.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@dimon222
Copy link
Collaborator Author

dimon222 commented Sep 25, 2019

@kevin-bates if u could provide the details on error for docs build failure (I believe its only visible for people with higher ownership in this repo), maybe we could cover it in this PR as well, as it anyway somewhat part of documentation piece.

I mean this badge:
image

@kevin-bates
Copy link
Member

ok - I'll try to take a look. That stuff is a bit of mystery to me.

@kevin-bates
Copy link
Member

@dimon222 - looks like @toidi is the sole maintainer. The last build was the failure nearly two years ago. I can't really see anything apparently wrong. https://readthedocs.org/projects/python-client-for-hadoop-yarn-api/builds/6260674/

Since these have been failing for some time and we need more access/information, I think we should move on.

@kevin-bates kevin-bates self-requested a review September 25, 2019 22:38
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks. We'll address the 20 month-old doc build issues later.

@dimon222
Copy link
Collaborator Author

dimon222 commented Sep 25, 2019

@kevin-bates I agree. Btw, I'm able to run build from my own fork without issues. I think github token that was used for Oauth to pull repo is no longer valid. If you or @lresende could request/register on readthedocs (maybe it can inherit access permissions from anyone who has access to change repository), it might refresh that Oauth token and start generating docs correctly.
image

The main problem is that new documentation is not being generated, so people might get confused by incompatible API signatures (since we significantly changed it since then)

@kevin-bates
Copy link
Member

Given the docs build locally for you, I'm going ahead with the merge. Thank you!

@kevin-bates kevin-bates merged commit 72d56bd into gateway-experiments:master Sep 25, 2019
@dimon222 dimon222 deleted the feature/better_readme branch September 25, 2019 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme rewrite
2 participants