Fix HTTPS uri parsing and add tests for it #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lresende
approved these changes
Dec 30, 2019
dimon222
force-pushed
the
bugfix/better_url_parsing
branch
from
0f1462b
to
3fcad65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was typo in condition (
andvsor) which could cause side effects. This PR fixes it. + There was rare scenario when url has http/https in the beginning of domain. This PR will check proper part of url with://.+
To reduce amount of confusion/random regressions I've added tests for url parsing.
PS: @lresende @kevin-bates The patch for
urlparsewas backported to earlier pythons in sub version (for ex. 3.7.6), so unfortunately this #71 won't completely save us (#69 (comment)) . As soon as somebody updates to new version of python, they might get in issues when they use this specific kind of URLtest.com:1234(with no schema specified). To mitigate this, we have to make sure we cover corner cases - this PR, and then perhaps release another hotfix version on Pypi.