Load Balancer API intergration #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I will review this today and merge it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am opening this pull request to see if you guys would be interested in merging my load balancer implementation.
This is a bit different than the rest of the API calls in this library. The DO load balancer API requires that you pass in full state representations of your load balancer on update, and also requires several smaller object maps for creating a new load balancer.
Because of this, I decided to make use of the Entity classes. These new LB calls will allow the user to pass in entities or arrays into methods as opposed to the standard primitives that the other calls normally utilize. I went this direction so I could build out my load balancer models with the benefit of my IDEs intellisense.