Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move login failure text to i18n #18

Open
scottrobertson opened this issue Jan 22, 2021 · 1 comment
Open

Move login failure text to i18n #18

scottrobertson opened this issue Jan 22, 2021 · 1 comment
Assignees
@marcqualie
Milestone
1.0.0

Comments

@scottrobertson
Copy link
Contributor

This text should be stored in either i18n, or in Tokenable::Config.

https://github.com/tokenable/tokenable-ruby/blob/main/lib/tokenable/controllers/tokens_controller.rb#L8
@scottrobertson scottrobertson mentioned this issue Jan 22, 2021
Open
@scottrobertson
Copy link
Contributor Author

Should be added to installer too, similar to how Devise does it:

https://github.com/heartcombo/devise/blob/45b831c4ea5a35914037bd27fe88b76d7b3683a4/lib/generators/devise/install_generator.rb#L33-L35

@marcqualie marcqualie added this to the 1.0.0 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcqualie marcqualie

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@scottrobertson @marcqualie