Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Connection lost errors on macos #64

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Conversation

vrajat
Copy link
Member

@vrajat vrajat commented Jul 17, 2021

Postgres connections are dropped when database is running in the host machine.
This solution adds a parameter to SQLAlchemy to ping the database and reconnect if it is dropped.
This is pessimistic and may add latency. However it is the easiest solution.

Refer:

@codecov
Copy link

codecov bot commented Jul 17, 2021

Codecov Report

Merging #64 (066446b) into master (1091e61) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #64   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files           8        8           
  Lines        1054     1054           
  Branches      103      103           
=======================================
  Hits          868      868           
- Misses        155      156    +1     
+ Partials       31       30    -1     
Impacted Files Coverage Δ
data_lineage/server.py 66.25% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1091e61...066446b. Read the comment docs.

@vrajat vrajat merged commit 49a86e6 into tokern:master Jul 17, 2021
@vrajat vrajat deleted the lost_connection branch July 17, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant