Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong test cases #21

Closed
Jack-Works opened this issue Jul 12, 2018 · 1 comment
Closed

Wrong test cases #21

Jack-Works opened this issue Jul 12, 2018 · 1 comment
Labels

Comments

@Jack-Works
Copy link
Contributor

Jack-Works commented Jul 12, 2018

  1. WeekMap -> WeakMap
    https://github.com/Tokimon/es-feature-detection/blob/master/builtins/es2015.json#L14

  2. WeekSet -> WeakSet
    https://github.com/Tokimon/es-feature-detection/blob/master/builtins/es2015.json#L15

  3. Number.isFininte -> Number.isFinite
    https://github.com/Tokimon/es-feature-detection/blob/master/builtins/es2015.json#L35

  4. RegExp.prototype.sticky
    https://github.com/Tokimon/es-feature-detection/blob/master/syntax/es2015.json#L4:21

(new RegExp('foo','y')).sticky === true
  1. RegExp.prototype.unicode
(new RegExp('\u{61}', 'u')).unicode === true
@Tokimon Tokimon added the bug label Oct 2, 2018
@Tokimon
Copy link
Owner

Tokimon commented Oct 2, 2018

Hey man thanks for the ticket.
I didn't get the notice about the post, so I only just saw your corrections. Amazing!
Thanks for helping out

@Tokimon Tokimon closed this as completed in 60454f9 Oct 2, 2018
Tokimon added a commit that referenced this issue Oct 2, 2018
Fix 3 typos, fix test for RegExp.sticky and RegExp.unicode, close #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants