Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow any IntoIterator for AppendHeaders #1493

Closed
jplatte opened this issue Oct 20, 2022 · 0 comments · Fixed by #1495
Closed

Allow any IntoIterator for AppendHeaders #1493

jplatte opened this issue Oct 20, 2022 · 0 comments · Fixed by #1495
Labels
A-axum breaking change A PR that makes a breaking change. C-enhancement Category: A PR with an enhancement E-easy Call for participation: Experience needed to fix: Easy / not much
Milestone
0.6

Comments

@jplatte
Copy link
Member

jplatte commented Oct 20, 2022

As per #927 (comment)

This is a breaking change, so we should do it before 0.6.0.
@jplatte jplatte added C-enhancement Category: A PR with an enhancement E-easy Call for participation: Experience needed to fix: Easy / not much breaking change A PR that makes a breaking change. A-axum labels Oct 20, 2022
@jplatte jplatte added this to the 0.6 milestone Oct 20, 2022
@jplatte jplatte mentioned this issue Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-axum breaking change A PR that makes a breaking change. C-enhancement Category: A PR with an enhancement E-easy Call for participation: Experience needed to fix: Easy / not much
Projects
None yet
Milestone
0.6
Development

Successfully merging a pull request may close this issue.

Generalize AppendHeaders to accept any impl IntoIterator tokio-rs/axum
1 participant
@jplatte