Fix expiration and upppercase check #72
Conversation
gallir
commented
Jan 3, 2021
gallir
commented
- While constructing the frame, expiration is not checked: added a check and the additional bytes, i.e. PX ms.
- When parsing from "EX" or "PX", it accepts only upper case, added to_uppercase() to the comparison.
|
I don't think bug fixes are in the spirit of this repository, as described by the README's warnings... |
There was a problem hiding this comment.
@seanpianka Bug fixes and new features are not the same thing. Mini-redis should of course correctly implement the features it has, even if we don't accept new features.
Which universe? It's a bug fix and from README.md: |
src/cmd/set.rs
Outdated
| @@ -146,6 +146,11 @@ impl Set { | |||
| frame.push_bulk(Bytes::from("set".as_bytes())); | |||
| frame.push_bulk(Bytes::from(self.key.into_bytes())); | |||
| frame.push_bulk(self.value); | |||
| if let Some(ms) = self.expire { | |||
| // Add expiration in milliseconds: SET key value PX ms | |||
There was a problem hiding this comment.
Can you please elaborate this comment so it explains that px means milliseconds, and perhaps also that ex would mean seconds? Currently it is just an arbitrary string if the user is not familiar with this part of the redis protocol.
You've won this round. |
