Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TcpSocket with socket2::Socket #1381

Closed
Thomasdezeeuw opened this issue Oct 29, 2020 · 1 comment
Closed

Replace TcpSocket with socket2::Socket #1381

Thomasdezeeuw opened this issue Oct 29, 2020 · 1 comment
Milestone

Comments

@Thomasdezeeuw
Copy link
Collaborator

Recently the socket2 crate moved to a new home: https://github.com/rust-lang/socket2-rs, and it is to become the socket implementation for the std lib. For v0.8 I would like to remove the TcpSocket type and instead let users use the Socket type from the socket2 crate.

I personally not looking forward for the stream of prs adding each and every method socket2::Socket already has, such as #1379 and #1375. Since I also maintain socket2, I don't want to maintain the same code twice.

@Thomasdezeeuw
Copy link
Collaborator Author

Not adding socket2 as a dependency, instead we're dropping the TcpSocket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant