Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move connect() from event_loop to net #47

Closed
rrichardson opened this issue Nov 11, 2014 · 3 comments
Closed

Move connect() from event_loop to net #47

rrichardson opened this issue Nov 11, 2014 · 3 comments

Comments

@rrichardson
Copy link
Contributor

It is a violation of the most fundamental layers of abstraction rules. It also violates any other notions of abstration. Event_loops don't "connect". Sockets "connect". It's driving me fucking crazy.
@rrichardson
Copy link
Contributor Author

I should point out that it is simple to sidestep any potential race conditions with registration by registering the socket before connecting. Also, I should point out that having the user connect then register doesn't put the system at any greater danger than using event_loop::connect's version. They'd be identical.

@carllerche
Copy link
Member

It's been in my list of things to do, but now I'm almost tempted to leave it out of spite ;)

If you provide a PR that moves it, I'll take it.

@rrichardson rrichardson mentioned this issue Nov 15, 2014
Closed
@carllerche
Copy link
Member

This has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carllerche @rrichardson