Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade windows dependencies #870

Closed
kpcyrd opened this issue Aug 20, 2018 · 4 comments
Closed

Upgrade windows dependencies #870

kpcyrd opened this issue Aug 20, 2018 · 4 comments
Labels
windows Related to the Windows OS.

Comments

@kpcyrd
Copy link

kpcyrd commented Aug 20, 2018

hey!

I've noticed the windows dependencies are outdated:

  • winapi 0.2 was bumped to 0.3
  • miow 0.2 was bumped to 0.3
  • kernel32-sys 0.2 was been superseded by winapi 0.3

Getting this fixed would allow us to upload mio into debian, which is a significant step of uploading tokio.

Thanks!

@hawkw
Copy link
Member

hawkw commented Aug 20, 2018

I believe updating the winapi version is a breaking change, which is why this hasn't been done yet (see carllerche/iovec#16 (comment), #658). IIRC, updating the winapi dependency to 0.3 is planned for the 0.7 release of mio.

@hawkw hawkw added windows Related to the Windows OS. waiting labels Aug 20, 2018
@steffengy
Copy link
Contributor

It actually landed in the 0.7 branch in january.
Since the plan is/was to finish the remaining work for the 0.7 milestone to bundle up breaking changes,
I would - taking the past 6 months into account - not bank on this being released any time soon.

@carllerche
Copy link
Member

As mentioned, it is a breaking change with far reaching impact.

The original plan has been to coordinate the release w/ futures, but I do not know when they plan to release now.

Either way, I will close this as the upgrade is being tracked.

@kpcyrd
Copy link
Author

kpcyrd commented Aug 29, 2018

Is there a patch we could apply in debian to get mio 0.6 to work with winapi 0.3?

Given this was fixed in January and a release is not going to happen in the foreseeable future, did you consider splitting up the release until smaller releases? As somebody who pushed out a whole bunch of pull requests to update dependencies recently, adapting to 3 breaking changes over 3 releases or 3 breaking changes in a single release doesn't make much of a difference from a library consumer point of view. I've noticed that large breaking updates are actually more likely to cause outdated dependencies because it's too much effort at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Related to the Windows OS.
Projects
None yet
Development

No branches or pull requests

4 participants