Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tokio::io::PollEvented please #3115

Closed
open-trade opened this issue Nov 10, 2020 · 8 comments
Closed

Expose tokio::io::PollEvented please #3115

open-trade opened this issue Nov 10, 2020 · 8 comments
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request.

Comments

@open-trade
Copy link

open-trade commented Nov 10, 2020

Widely used by the other crates, it is hard to upgrade these crates without PollEvented, Currently PollEvented is only crate visible, please make it outside visible.

@open-trade open-trade added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Nov 10, 2020
@Darksonn
Copy link
Contributor

PollEvented uses the mio crate in its public API, which we don't want to do anymore. Alternate apis are needed.

@Keruspe
Copy link
Contributor

Keruspe commented Nov 10, 2020

Did you give AsyncFd a look?

@open-trade
Copy link
Author

open-trade commented Nov 10, 2020

Did you give AsyncFd a look?

My use case has no underlying Unix file descriptor. I wanna wrap mio/src/sys/windows/named_pipe.rs

@carllerche
Copy link
Member

I opened #3118 to track named pipes.

We cannot expose Mio as part of the public API as we may wish to alter the internals to avoid Mio (perhaps uring).

@benjumanji
Copy link

benjumanji commented Nov 29, 2020

Alternate apis are needed.

It might have been nice to not make upgrading impossible until those newer apis were created.

@carllerche
Copy link
Member

Feel free to submit a PR adding named to pipe support. As an open source project, we have limited resources and make decisions based on what we are able to get done.

@benjumanji
Copy link

Feel free to submit a PR adding named to pipe support.

I don't need named pipe support.

@ZoeyR
Copy link
Contributor

ZoeyR commented Jan 18, 2021

It is a shame that unix is getting preferential treatment here with the AsyncFd trait. There will inevitably be developer requirements that will not be met by the built-in windows types. For instance the proposed named pipes PR doesn't have security descriptors, and given the breadth of windows APIs I doubt there will ever be a complete solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request.
Projects
None yet
Development

No branches or pull requests

6 participants