chore: fix stress test #3233
Merged
chore: fix stress test #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI run 1515308234 reported that the command Run apt install -y valgrind failed due to missing root permissions. This patch adds sudo before the apt install to overcome this.
taiki-e
requested changes
Dec 8, 2020
There was a problem hiding this comment.
This workflow is not enabled for PR.
Please add pull_request condition to on key or move stress-test job to ci.yml.
tokio/.github/workflows/stress-test.yml
Lines 2 to 5 in e013913
on:
+ pull_request:
push:
branches:
- master
taiki-e
reviewed
Dec 8, 2020
Co-authored-by: Taiki Endo <te316e89@gmail.com>
taiki-e
reviewed
Dec 8, 2020
Co-authored-by: Taiki Endo <te316e89@gmail.com>
thanks for the great feedback! |
taiki-e
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI run 1515308234 reported that the command
Run apt install -y valgrind failed due to missing root permissions.
This patch adds sudo before the apt install to overcome this.
Motivation
Solution