Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JoinHandle::is_finished #4707

Closed
Darksonn opened this issue May 19, 2022 · 1 comment · Fixed by #4709
Closed

Add JoinHandle::is_finished #4707

Darksonn opened this issue May 19, 2022 · 1 comment · Fixed by #4709
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate M-task Module: tokio/task

Comments

@Darksonn
Copy link
Contributor

The standard library has just stabilized std::thread::JoinHandle::is_finished. I would like to see an analogous method added to our JoinHandle.
@Darksonn Darksonn added E-help-wanted Call for participation: Help is requested to fix this issue. A-tokio Area: The main tokio crate M-task Module: tokio/task C-feature-request Category: A feature request. E-medium Call for participation: Experience needed to fix: Medium / intermediate labels May 19, 2022
@hawkw
Copy link
Member

hawkw commented May 19, 2022

+1.

We should probably also add a similar method to AbortHandle while we're here.

@name1e5s name1e5s mentioned this issue May 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-feature-request Category: A feature request. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Experience needed to fix: Medium / intermediate M-task Module: tokio/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(runtime): add is_finished method for JoinHandle and AbortHandle name1e5s/tokio
2 participants
@Darksonn @hawkw