Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: fix tokio process abort issues on windows #4802

Closed
Noah-Kennedy opened this issue Jul 2, 2022 · 1 comment · Fixed by #4854
Closed

process: fix tokio process abort issues on windows #4802

Noah-Kennedy opened this issue Jul 2, 2022 · 1 comment · Fixed by #4854
Assignees
Labels
C-bug Category: This is a bug. M-process Module: tokio/process

Comments

@Noah-Kennedy
Copy link
Contributor

Unfortunately, as a result of rust-lang/rust#95469, we can no longer use tokio::process to communicate with child processes which are themselves rust binaries using std or tokio for stdio. Doing so may result in the child process being aborted.

This was the cause of #4801.

Unfortunately, this doesn't have an easy solution. What we probably need to do is either have the normal stdio stuff use mio, or have the child process stdio use the blocking pool. The latter is very much the better option since we don't want to risk causing issues by setting stdin/stdout to be nonblocking on windows.

@Noah-Kennedy Noah-Kennedy added M-process Module: tokio/process C-bug Category: This is a bug. labels Jul 2, 2022
@Noah-Kennedy
Copy link
Contributor Author

CC @ipetkov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. M-process Module: tokio/process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants