Request: a way of catching any windows signal.

[jkelleyrtp]

Right now it seems that tokio only exports signal handlers for ctrl_c and ctrl_break for windows, while for Unix, you can trap any signal covered by SignalKind.

It would be great if there was a method that would allow creating an RxFuture for any of the signal types in the winapi crate.

This method already exists, but it's marked private. It would be great if this were public and given a new name so I could trap the various other windows signals that exist.

tokio/tokio/src/signal/windows/sys.rs

Line 20 in 4b1c480

fn new(signum: DWORD) -> io::Result<RxFuture> {

[Noah-Kennedy]

I don't have any issues with doing this, but I'd like to know why it's marked as private first.

[ipetkov]

but I'd like to know why it's marked as private first.

@Noah-Kennedy just to start out with a conservative API surface and no one has asked for it until now 😄

@jkelleyrtp which signals are you interested in receiving?

I see win API has other events like CTRL_CLOSE_EVENT/CTRL_LOGOFF_EVENT/CTRL_SHUTDOWN_EVENT we can easily add these in as a concrete public API. I'm not philosophically opposed to having more of a general signal solution like we do on Unix platforms, though I'm not very familiar with the windows signal semantics and if they are analogous to the Unix ones

[schultetwin1]

The only event we need for now is CTRL_CLOSE_EVENT. CTRL_LOGFF_EVENT and CTRL_SHUTDOWN_EVENT can be added as well but if you want to keep with the them of a conservative API, we'd be happy with just CTRL_CLOSE_EVENT.

[jkelleyrtp]

I'll put up a branch here in a sec.