Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: use criterion crate instead of bencher crate in benchmark #5979

Closed
wathenjiang opened this issue Sep 4, 2023 · 1 comment · Fixed by #5981
Closed

Proposal: use criterion crate instead of bencher crate in benchmark #5979

wathenjiang opened this issue Sep 4, 2023 · 1 comment · Fixed by #5981
Labels
A-benches Area: Benchmarks C-feature-request Category: A feature request.

Comments

@wathenjiang
Copy link
Contributor

wathenjiang commented Sep 4, 2023

The current benchmark crate is bencher, but the criterion is more modern and being maintained, which can be found here.

I would like to do more benchmarks, but I found the API of bencher is kind of poor, such as the lack of iter_custom in criterion.

If this proposal can be passed, I would like to help compelete it.

@wathenjiang wathenjiang added A-tokio Area: The main tokio crate C-feature-request Category: A feature request. labels Sep 4, 2023
@Darksonn Darksonn added A-benches Area: Benchmarks and removed A-tokio Area: The main tokio crate labels Sep 4, 2023
@Darksonn
Copy link
Contributor

Darksonn commented Sep 4, 2023

I don't mind changing the benchmarks to criterion. Go ahead and file a PR if you want to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benches Area: Benchmarks C-feature-request Category: A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants