Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup CI #28

Closed
mcches opened this issue Sep 21, 2022 · 3 comments · Fixed by #31
Closed

Setup CI #28

mcches opened this issue Sep 21, 2022 · 3 comments · Fixed by #31
Labels
good first issue Good for newcomers

Comments

@mcches
Copy link
Contributor

mcches commented Sep 21, 2022

At min we should run a full build per PR.

See: https://github.com/jonhoo/rust-ci-conf
@mcches mcches added the good first issue Good for newcomers label Sep 21, 2022
@mcches mcches linked a pull request Sep 22, 2022 that will close this issue
Fix error in README.md #31
Merged
@marcbowes
Copy link
Contributor

We now run a build per PR, but there are some other things to do such as:

  • setup build badges
  • run clippy and/or other things

@marcbowes marcbowes reopened this Sep 22, 2022
@mcches
Copy link
Contributor Author

mcches commented Sep 28, 2022

Add badge: #33

@MarinPostma MarinPostma mentioned this issue Nov 22, 2022
Merged
@mcches
Copy link
Contributor Author

mcches commented Jan 9, 2023

clippy is running, i'm going to close this.

@mcches mcches closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error in README.md marcbowes/turmoil
2 participants
@marcbowes @mcches