Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHT_bootstrap should not link against misc_tools #1144

Closed
eclipseo opened this issue Aug 31, 2018 · 2 comments
Closed

DHT_bootstrap should not link against misc_tools #1144

eclipseo opened this issue Aug 31, 2018 · 2 comments
Labels
good first issue Good first issue P3 Low priority
Milestone
v0.2.19

Comments

@eclipseo
Copy link

eclipseo commented Aug 31, 2018 •
edited

DHT_bootstrap is linked with libmisc_tools.so but it is not installed alongside which means it can't find it.

Unless DHT_bootstrap is not meant to be installed along the library?
@eclipseo
Copy link
Author

Looks like DHT_bootstrap is only using hex_string_to_bin from libmisc_tools.so. Seems excessive to ship a whole unversioned library just for that.

@iphydf
Copy link
Member

iphydf commented Aug 31, 2018

Agreed. Let's fix that. We used to not install that binary, only recently started doing so. I didn't think of dynamically linked tools.

@iphydf iphydf added this to the v0.2.x milestone Sep 17, 2018
@iphydf iphydf added the P3 Low priority label Apr 27, 2020
@iphydf iphydf changed the title libmisc_tools.so not installed tox-bootstrapd should not link against misc_tools Feb 4, 2022
@iphydf iphydf added the good first issue Good first issue label Feb 7, 2022
@iphydf iphydf modified the milestones: v0.2.x, v0.2.17 Feb 18, 2022
@iphydf iphydf changed the title tox-bootstrapd should not link against misc_tools DHT_bootstrap should not link against misc_tools Feb 23, 2022
@iphydf iphydf modified the milestones: v0.2.17, v0.2.19 Feb 28, 2022
@iphydf iphydf modified the milestones: v0.2.19, v0.2.20 Apr 18, 2022
Green-Sky added a commit to Green-Sky/c-toxcore that referenced this issue Oct 4, 2022
@Green-Sky
fix: TokTok#1144 by forcing misc_tools to be a static lib
39f5c24
Green-Sky added a commit to Green-Sky/c-toxcore that referenced this issue Oct 7, 2022
@Green-Sky
fix: TokTok#1144 by forcing misc_tools to be a static lib
2187893
@sudden6 sudden6 closed this as completed in e1c38b4 Dec 8, 2022
zoff99 pushed a commit to zoff99/c-toxcore that referenced this issue Dec 10, 2022
@Green-Sky @zoff99
fix: TokTok#1144 by forcing misc_tools to be a static lib
d0c44d9
@iphydf iphydf modified the milestones: v0.2.20, v0.2.19 Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issue P3 Low priority
Projects
None yet
Milestone
v0.2.19
Development

No branches or pull requests
2 participants
@iphydf @eclipseo