Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-msgpack-0.0.5 benchmark build failure #20

Closed
DanBurton opened this issue Oct 24, 2016 · 6 comments
Closed

data-msgpack-0.0.5 benchmark build failure #20

DanBurton opened this issue Oct 24, 2016 · 6 comments
Assignees

Comments

@DanBurton
Copy link

DanBurton commented Oct 24, 2016

As seen on the stackage build server:

Preprocessing executable 'msgpack-parser' for data-msgpack-0.0.5...
[1 of 1] Compiling Main             ( tools/msgpack-parser.hs, dist/build/msgpack-parser/msgpack-parser-tmp/Main.o )
Linking dist/build/msgpack-parser/msgpack-parser ...
Preprocessing benchmark 'benchmark' for data-msgpack-0.0.5...
[1 of 1] Compiling Main             ( bench/benchmark.hs, dist/build/benchmark/benchmark-tmp/Main.o )

bench/benchmark.hs:6:1: error:
    Failed to load interface for ‘Data.MessagePack.IntBench’
    Perhaps you meant
      Data.MessagePack.Instances (from data-msgpack-0.0.5)
      Data.MessagePack.Object (from data-msgpack-0.0.5)
      Data.MessagePack.Spec (needs flag -package-key messagepack-0.5.3)
    Use -v to see a list of the files searched for.

bench/benchmark.hs:7:1: error:
    Failed to load interface for ‘Data.MessagePackBench’
    Perhaps you meant
      Data.MessagePack (from data-msgpack-0.0.5)
      Data.MessagePack (needs flag -package-key messagepack-0.5.3)
      Data.MessagePack.Get (from data-msgpack-0.0.5)
    Use -v to see a list of the files searched for.

How I reproduced this locally:

$ stack unpack data-msgpack-0.0.5
$ cd data-msgpack
$ stack init --resolver nightly-2016-10-24
$ stack build --bench
DanBurton added a commit to commercialhaskell/stackage that referenced this issue Oct 24, 2016
@iphydf iphydf self-assigned this Oct 24, 2016
@iphydf
Copy link
Member

iphydf commented Oct 24, 2016

Working on it.

@iphydf
Copy link
Member

iphydf commented Oct 24, 2016

Fixed in 0.0.6. Thanks for the report.

@iphydf iphydf closed this as completed Oct 24, 2016
iphydf added a commit to iphydf/stackage that referenced this issue Oct 24, 2016
... as they are now fixed. TokTok/hs-msgpack-binary#20 - fixed in 0.0.6.
@DanBurton
Copy link
Author

I still get the same error when I follow the repro steps with 0.0.6

$ stack unpack data-msgpack-0.0.6
$ cd data-msgpack
$ stack init --resolver nightly-2016-10-24
$ stack build --bench

@iphydf iphydf reopened this Oct 27, 2016
@iphydf
Copy link
Member

iphydf commented Oct 27, 2016

@DanBurton I tried again.. cabal sdist fails to add the benchmark modules. I hackishly created my own tarball and uploaded it.

iphydf added a commit to iphydf/hs-msgpack-binary that referenced this issue Oct 27, 2016
`cabal sdist` doesn't include bench modules.

Fixes TokTok#20
Fixes TokTok#25
@DanBurton
Copy link
Author

Note that the tarball is actually missing the test suite module files

├── test
│   └── testsuite.hs

That's all there is in the test folder of the tarball. So the test suite might still pass, but only trivially so. I believe the solution is to specify other-modules listing the modules used by each build target, or other-source-files at the top level of the cabal file, which allows for some globbing expressions.

iphydf added a commit to iphydf/hs-msgpack-binary that referenced this issue Oct 29, 2016
`cabal sdist` doesn't include bench and test modules.

Fixes TokTok#20
Fixes TokTok#25
@iphydf
Copy link
Member

iphydf commented Oct 29, 2016

I see. Thanks for noting that. I've fixed that in #26 now, using other-source-files.

iphydf added a commit to iphydf/hs-msgpack-binary that referenced this issue Nov 2, 2016
`cabal sdist` doesn't include bench and test modules.

Fixes TokTok#20
Fixes TokTok#25
iphydf added a commit to iphydf/hs-msgpack-binary that referenced this issue Nov 2, 2016
`cabal sdist` doesn't include bench and test modules.

Fixes TokTok#20
Fixes TokTok#25
@iphydf iphydf closed this as completed in #26 Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants