Cloned object make different SQL from the original. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktat
changed the title
|
The following is the result of t/select/03_clone.t with current version of SQL::Maker. |
ktat
force-pushed
the
feature/fix-cloned-object
branch
from
71c2c8b
to
fe431ea
Compare
tokuhirom
added a commit
that referenced
this pull request
Nov 1, 2022
Changelog diff is:
diff --git Changes Changes
index d6876e2..2d965d5 100644
--- Changes
+++ Changes
@@ -2,6 +2,12 @@ Revision history for Perl module SQL::Maker
{{$NEXT}}
+1.22 2022-11-01T03:02:16Z
+
+ Cloned object make different SQL from the original. #51
+ #51
+ (ktat)
+
1.21 2014-12-22T06:27:33Z
Official support for directly passing a SQL::QueryMaker object as $where parameter #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About SQL::Maker::select_query,
If it has scalar reference in select, SQL from cloned object is not same SQL with the one from an original object.
It causes that scalar reference's address is used as key of
select_map.So, in this fix, creating select_map from select_map_reverse in
as_sql.And if single scalar reference is given as
$termin select, dereference it and set it to $col before$col ||= $term.