Skip to content
This repository has been archived by the owner on Oct 1, 2023. It is now read-only.

Missing variables #17

Closed
jrappen opened this issue May 20, 2020 · 1 comment
Closed

Missing variables #17

jrappen opened this issue May 20, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jrappen
Copy link
Contributor

jrappen commented May 20, 2020

Hello @tolking,

could you add some variables (for me) to your theme?

Found these missing while looking at @vuepress/core/lib/client/style/config.styl:

  • $badgeTipColor (and dark variant)
  • $badgeWarningColor (and dark variant)
  • $badgeErrorColor (and dark variant)

Found these missing while testing your theme and looking at styles/palette.styl:

  • $tipColor (and dark variant)
  • $lighten10AccentColor (and dark variant)
  • $lighten10TextColor (and dark variant)
  • $lighten20TextColor (and dark variant)
  • $lighten25TextColor (and dark variant)
  • $lighten35TextColor (and dark variant)
  • $lighten40TextColor (and dark variant)
  • $darken10AccentColor (and dark variant)
  • $darken10BgColor (and dark variant)
  • $darken10BorderColor (and dark variant)

Thanks!

@tolking tolking added the enhancement New feature or request label May 20, 2020
@tolking tolking reopened this May 24, 2020
@tolking
Copy link
Owner

tolking commented May 24, 2020

add

  • $badgeTipColor
  • $badgeWarningColor
  • $badgeErrorColor
  • $tipColor

about

  • $lighten10AccentColor
  • $lighten10TextColor
    ...
    I don't think it's necessary to add these variables

modify in this way

// .vuepress -> styles -> index.styl
:root
  --lighten10AccentColor #ff0000
  --lighten10TextColor #777777
  //...
  @media (prefers-color-scheme dark)
    --lighten10AccentColor #ffff00
    --lighten10TextColor #aaaaaa
    //...

@tolking tolking closed this as completed May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants