Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only launch Puppeteer if browser is needed #11

Open
tolmasky opened this issue Apr 10, 2019 · 2 comments
Open

Only launch Puppeteer if browser is needed #11

tolmasky opened this issue Apr 10, 2019 · 2 comments
Milestone

Comments

@tolmasky
Copy link
Owner

tolmasky commented Apr 10, 2019

We need to see how this affects performance. It would make lithograph much more viable for unit testing. Worst case scenario, flag to turn browsers off.

@tolmasky tolmasky added this to the 1.0-RC milestone Apr 10, 2019
@noahlt
Copy link

noahlt commented Apr 10, 2019

Curious about your thoughts regarding how this would work (though I don't quite know how things work at the moment) — I guess we could just not launch Puppeteer at all until a Puppeteer API is called? (and then keep puppeteer/browser around for the rest of the run, assuming that the OS can manage things properly?)

@tolmasky
Copy link
Owner Author

Yes what I want to try first is just not launching Chrome instances until they are requested. The main question for me is whether the startup time of Chrome will cause significant regressions for our tests that all know ahead of time that they want to make use of Chrome instances. However, I think we currently wait for all instances to boot up before starting any tests, so this may end up working itself out. The main downside scenarios are when you have tons of files that don't make use of Chrome and then one that does, the Chrome instance could have been booting up in parallel theoretically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants