Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize test queue by comparing open scope depth #2

Open
tolmasky opened this issue Dec 2, 2018 · 1 comment
Open

Prioritize test queue by comparing open scope depth #2

tolmasky opened this issue Dec 2, 2018 · 1 comment

Comments

@tolmasky
Copy link
Owner

tolmasky commented Dec 2, 2018

Right now tests are run in the order they are reached in our tree traversal. This can be suboptimal if a bunch of tests are queued while a serial test with an open scope is running, because then the next test with access to that scope will be placed in the back of the queue. This will maximize browser starvation, along with just keeping around a lot more garbage than we need. We should decide which test to do next by how many open scopes it has.

@tolmasky
Copy link
Owner Author

tolmasky commented Dec 2, 2018

Perhaps prioritize first by open scope depth with browsers, and secondly by absolute depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant