Skip to content
This repository has been archived by the owner on Apr 8, 2020. It is now read-only.

Add setup and tear down logic #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add setup and tear down logic #60

wants to merge 5 commits into from

Conversation

polina-popova
Copy link
Contributor

@polina-popova polina-popova commented Jan 30, 2019 •
edited
Loading

Closes #53

@polina-popova polina-popova requested a review from a team January 30, 2019 12:51
@polina-popova polina-popova changed the title Use RocketChat API calls Add setup and tear down logic Feb 1, 2019
@polina-popova polina-popova force-pushed the replace_func_by_api branch 3 times, most recently from 2f16794 to a9821f8 Compare February 1, 2019 13:40
eugulixes
eugulixes reviewed Feb 12, 2019
View reviewed changes
base.py Outdated Show resolved Hide resolved
eugulixes
eugulixes reviewed Feb 12, 2019
View reviewed changes
base.py Outdated Show resolved Hide resolved
eugulixes
eugulixes reviewed Feb 12, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
eugulixes
eugulixes reviewed Feb 12, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@polina-popova polina-popova force-pushed the replace_func_by_api branch 4 times, most recently from de56696 to 9516951 Compare February 12, 2019 12:28
@polina-popova
Copy link
Contributor Author

rocketchat-tests: добавить методы setup и tear_down

ya7on
ya7on reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@ya7on ya7on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After tear down in terminal is written some tracebacks

02/14/2019 11:29:29 AM Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f85fad14ac8>: Failed to establish a new connection: [Errno 111] Connection refused')': /session/***
02/14/2019 11:29:29 AM Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f85fad14cf8>: Failed to establish a new connection: [Errno 111] Connection refused')': /session/***
02/14/2019 11:29:29 AM Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f85fad14860>: Failed to establish a new connection: [Errno 111] Connection refused')': /session/***

@ABSLord
Copy link
Contributor

ABSLord commented Feb 14, 2019

Need to remove create_test_user=False from vote_or_die_script_tests.py:
test_cases = VoteOrDieScriptTestCase(options.host, options.username, options.password, create_test_user=False)

ya7on
ya7on reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@ya7on ya7on left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to catch exception when RocketChat API is not logged in

@ABSLord ABSLord changed the title Add setup and tear down logic [WIP] Add setup and tear down logic Feb 19, 2019
polina-popova
polina-popova commented Feb 20, 2019
View reviewed changes
base.py Outdated Show resolved Hide resolved
@ABSLord ABSLord force-pushed the replace_func_by_api branch 4 times, most recently from 008f919 to 10ad573 Compare February 20, 2019 16:30
@polina-popova polina-popova force-pushed the replace_func_by_api branch 2 times, most recently from eb112b8 to f965611 Compare March 6, 2019 13:02
ya7on
ya7on suggested changes Mar 11, 2019
View reviewed changes
base.py Outdated Show resolved Hide resolved
base.py Outdated Show resolved Hide resolved
base.py Outdated Show resolved Hide resolved
base.py Outdated Show resolved Hide resolved
base.py Outdated Show resolved Hide resolved
base.py Outdated Show resolved Hide resolved
base.py Outdated Show resolved Hide resolved
ya7on
ya7on suggested changes Mar 11, 2019
View reviewed changes
happy_birthder_script_tests.py Outdated Show resolved Hide resolved
rc_tests.py Outdated Show resolved Hide resolved
@ya7on ya7on self-requested a review March 11, 2019 12:14
@polina-popova polina-popova force-pushed the replace_func_by_api branch 2 times, most recently from 2608439 to 5b6706d Compare March 11, 2019 13:44
@polina-popova polina-popova force-pushed the replace_func_by_api branch 2 times, most recently from 1a4d2e4 to 617f8b9 Compare March 27, 2019 13:16
@polina-popova polina-popova force-pushed the replace_func_by_api branch 8 times, most recently from 681aee8 to d6424ae Compare April 5, 2019 13:58
@polina-popova polina-popova changed the title [WIP] Add setup and tear down logic Add setup and tear down logic Apr 5, 2019
eugulixes
eugulixes reviewed Apr 5, 2019
View reviewed changes
happy_birthder_script_tests.py Outdated
@@ -87,6 +92,27 @@ def _wait_reminder(self):
# Public methods
#

def tear_down(self):
"""Makes clean up of the testing enviroment. """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There is a typo in enviroment.
  • Let's rewrite the docstring: Cleans up the testing environment

@polina-popova polina-popova force-pushed the replace_func_by_api branch 2 times, most recently from c213b58 to c1345d3 Compare April 16, 2019 14:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eugulixes eugulixes eugulixes left review comments

@ABSLord ABSLord Awaiting requested review from ABSLord

@ya7on ya7on Awaiting requested review from ya7on

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide the clean up at the tests end
4 participants
@polina-popova @ABSLord @eugulixes @ya7on