-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Download only missing images when anabling offline mode #228
Comments
@tom-anders is this something you agree with and something i can start work on? |
@markolo25 Definitely, go for it! |
I had started to work on a patch yesterday and I'm in the middle of finishing it up; I guess we can see how our implementations differ. |
Closing this along with the PR |
Thanks! This works very well now. One thing i noticed is that Easy xkcd version I went ahead and wiped Easy xkcd's app data, copied the comic files i had to the |
Thanks for pointing that out, I think enabling offline mode should be blocked when offline. |
Use case
I regularly back up my
easy xkcd
folder, partly because i like to prevent that i have to download them again, partly because i also manually fixed a few images by manually downloading comics Easy xkcd didn't fetch properly for me.If needed, i simply restore that folder from a backup.
While setting up Easy xkcd on a new device, i see no option to prevent downloading exisiting images again.
I would like to have a way to tell the app to look for existing files in the offline directory (also for what-if) and re-use them instead of forcibly reloading all comics. I know that i can replace the
easy xkcd
directory after that but there might be situations where downloading ~200MB can be a problem, and at the very least is it unnecessary in my case and also takes up a few minutes.The text was updated successfully, but these errors were encountered: