Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Column Filter reset after adding a key #192

Closed
jongleur1983 opened this issue Nov 13, 2018 · 1 comment
Closed

Key Column Filter reset after adding a key #192

jongleur1983 opened this issue Nov 13, 2018 · 1 comment
Milestone

Comments

@jongleur1983
Copy link

jongleur1983 commented Nov 13, 2018

Many of our localization strings are located in the same file, but organized within this file by kind of namespacing pattern, let's say Domain.Task, Domain.TaskId, General.Ok, General.Cancel, SomeSpecialDialog.InfoTooltip

With this pattern I often filter the key column by the namespace prefix when adding entries. Let's say I'm working on SomeSpecialDialog, then a column filter to "SomeSpecialDialog." is handy to scope the view to all items of interest.

Applying that filter and adding the first new key currently removes the filter again. This is a useful approach whenever the filter doesn't match the new key - as the new item would not be visible at all.
If it is (as in the workflow described above) it shouldn't be necessary to clear the filter.

So I propose to only delete the filter of the key column if it doesn't match the key just created.

(for reference in case someone without deep knowledge to the code - as myself - works on it: ccda729 seems to be a good starting point, that's the commit where clearing the filter was introduced).

@tom-englert tom-englert added this to the 1.29 milestone Nov 13, 2018
@jongleur1983
Copy link
Author

great to see it happening - and incredibly fast. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants