Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux arm64 support #54

Open
jwillikers opened this issue Jun 6, 2020 · 13 comments
Open

Linux arm64 support #54

jwillikers opened this issue Jun 6, 2020 · 13 comments

Comments

@jwillikers
Copy link

I have a Pinebook Pro laptop which has arm64 processors. Would it be possible to release binaries for Linux arm64?

@tom-james-watson
Copy link
Owner

I'm not going to be able to do that at this point. I imagine you can build the app yourself. I'd also accept pull requests to get this working!

@jwillikers
Copy link
Author

When I have time, I'll see if I can build it 👍

@tom-james-watson
Copy link
Owner

@jwillikers
Copy link
Author

jwillikers commented Jun 12, 2020

@tom-james-watson Thanks for the link.

I was able to get everything working and running in the dev environment.

On the default Manjaro KDE distribution on the Pinebook Pro, I installed yarn and npm.

$ pacman -S yarn npm

Then, I followed the instructions on your link, but I had to run the upgrade command to get around an error.

$ yarn
$ yarn upgrade
$ yarn install
$ yarn dev

While I was able to build the package, a fatal error occurred when running yarn start.

$ yarn build
$ yarn start

The output of the failed yarn start command is here.
The icon node_modules/electron/dist/resources/app/resources/tray/icon.png does not exist.

@tom-james-watson
Copy link
Owner

That's actually a problem on master that I hadn't noticed.

Note - I've since switched back to npm.

Are you saying the app works ok in dev mode (npm run dev)?

If you want to test the production version, you want to package the app up: yarn package-linux. Then you should be able to find the built version of the production app under the release folder.

@jwillikers
Copy link
Author

The app works great in dev mode (npm run dev).

Running npm run package produces an AppImage which also works great!

@tom-james-watson
Copy link
Owner

That's great. I don't really have any way of building and publishing this myself at the moment, so I think this will just have to be unofficial support for now.

@jwillikers
Copy link
Author

@tom-james-watson Yeah, that makes sense. I really appreciate the help and support! 🙏

Emulating Arm64 on QEMU and building it on that might not be too difficult. I can always test that out on one of my amd64 machines and let you know how it goes, if you think that's viable.

@tom-james-watson
Copy link
Owner

Yeah sure if it's something that is easily reproducible then it could be something we could look at adding.

@marijnbent
Copy link

Will this also work for the Apple M1 processor?

@tom-james-watson
Copy link
Owner

I haven't got the hardware to try this out, so I'm not going to be able to produce official builds any time soon.

As far as I can tell from electron-userland/electron-builder#5392, if we upgrade electron and electron-builder then you should be able to manually build ARM64 macOS binaries without any changes.

@Catsvilles
Copy link

Latest version seems to be working fine on my Mac mini M1

@a-dows
Copy link

a-dows commented Jan 3, 2022

+1 for arm64 (M1 Mac) support, down to only two apps I run that are missing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants