Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An issue with the search function regarding galleries with updated ID numbers #147

Open
invokethe5th opened this issue Feb 17, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@invokethe5th
Copy link

Some galleries get updated and get assigned new ID numbers.

It seems that, when using the search function of the Pupil app, the search results shows only the newest ID numbers for the galleries. This is good in most cases.

The issue with this is that, if a favorited and/or downloaded gallery get assigned a new ID number, it no longer shows up in search results.

Users expect to be able to search for the galleries that they have already favorited and/or downloaded. If they no longer show up in the search results, users have to manually scroll through the favorites/download list to find them.

Could the search function be fixed so that favorited/downloaded galleries show up even when they have been updated and are associated with new ID numbers?

@tom5079
Copy link
Owner

tom5079 commented Feb 17, 2024

Favorited/downloaded galleries should and does show up on the search result on my devices. Can you provide me a video or reproducing steps?

@tom5079 tom5079 added the bug Something isn't working label Feb 17, 2024
@invokethe5th
Copy link
Author

I would like to clarify that this issue only happens to a small number of galleries that gets updated.

Reproducing steps:

Step 1: Download a gallery on a device using Pupil app. Let's say this gallery has an ID number of XXXX at the time of download.

Step 2: This downloaded gallery can be updated on the website with additional images, in which case it can get assigned a new ID number. For example, a gallery with ID number XXXX used to have 100 images, but it gets updated with 5 additional images, and now it has a new ID number of YYYY and has 105 images. (Both ID numbers XXXX and YYYY still works on the website and would resolve to the exact same gallery. In this case, multiple ID numbers seem to be associated with the same gallery.).
This is not a step a user can perform on Pupil app. This step is done by the uploader on the website.

Step 3: After the gallery is updated, search for this gallery on the home tab, using the author name. This gallery will show up as a new gallery with the ID number YYYY with 105 images. The downloaded gallery with ID number XXXX with 100 images will not show up on this search result.
(This YYYY gallery is treated separately from the downloaded gallery XXXX in the Pupil app. If I attempt to open this YYYY gallery, the Pupil app will attempt to download this new YYYY gallery from scratch, instead of showing the images from the downloaded XXXX gallery. )

Step 4: If I search for this gallery in the download tab using the author name, neither YYYY nor XXXX will show up. On one hand, it is expected that YYYY does not show up, since it's not downloaded. On the other hand, I expect that XXXX should still show up, because it's downloaded and stored in the device. However, since Pupil search function seems to ignore galleries with old ID numbers, it does not show up.

The only way to see this downloaded XXXX gallery is to not use the search function. If I go to download tab and scroll through all downloaded galleries, I can see it. It just will not show up on search results. Or i can use "open gallery by ID" function to open the downloaded gallery by typing XXXX.

@tom5079
Copy link
Owner

tom5079 commented Feb 17, 2024

Ohh, I see. Thank you for clarifying. I have to fix this by implementing a local search... Can you provide me a galleryID that had been reassigned?

@invokethe5th
Copy link
Author

This is an example gallery whose ID number changed twice.

  • Before 2023-12-28: 2777397
  • 2023-12-28: 2779847
  • Now: 2789262

@tom5079
Copy link
Owner

tom5079 commented Feb 24, 2024

Progress update: I decided to redesign the entire search page so it will take a while... Hang tight!

@invokethe5th
Copy link
Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants