Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-system] read the version from tags #64

Closed
Avinash-Bhat opened this issue Jul 23, 2016 · 3 comments
Closed

[build-system] read the version from tags #64

Avinash-Bhat opened this issue Jul 23, 2016 · 3 comments

Comments

@Avinash-Bhat
Copy link
Contributor

the apk version name could be easily loaded from git repository itself this is an added advantage for sending out releases as there will not be any need for commits for just changing the version.

As for the apk version code, the same could again be loaded from the git repository itself the build-script for this is available from https://gist.github.com/Avinash-Bhat/12fc59b3d96cb427e5e9 (this may require some tweaking)

I will send a PR so that you can look at this.

@Avinash-Bhat Avinash-Bhat changed the title [build-system] read the version code from tags [build-system] read the version from tags Jul 23, 2016
@Avinash-Bhat
Copy link
Contributor Author

Note that the above code is based on one of my stackoverflow answer 3 years ago.

@Avinash-Bhat
Copy link
Contributor Author

The PR calculates the version code by parsing the version name, like it is used before the change. so this should also work as intended.

@mrmaffen
Copy link
Member

mrmaffen commented Aug 2, 2016

Thanks! Your commit has been merged

@mrmaffen mrmaffen closed this as completed Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants