Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting implementations of trait platform::platform::x11::util::format::Formattable for type u8 #585

Closed
UK992 opened this issue Jul 2, 2018 · 6 comments
Labels
B - bug Dang, that shouldn't have happened C - in progress Implementation is proceeding smoothly DS - x11

Comments

@UK992
Copy link
Contributor

UK992 commented Jul 2, 2018

error[E0119]: conflicting implementations of trait `platform::platform::x11::util::format::Formattable` for type `u8`:
  --> /home/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.16.0/src/platform/linux/x11/util/format.rs:54:1
   |
53 | impl Formattable for c_char { const FORMAT: Format = Format::Char; }
   | --------------------------- first implementation here
54 | impl Formattable for c_uchar { const FORMAT: Format = Format::Char; }
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `u8`

In servo/servo#21087 (comment) on targets arm-unknown-linux-gnueabihf and aarch64-unknown-linux-gnu.

@francesca64 francesca64 added B - bug Dang, that shouldn't have happened DS - x11 C - in progress Implementation is proceeding smoothly labels Jul 2, 2018
@francesca64
Copy link
Member

Is this good? #586

I never considered that c_char could be unsigned, though fortunately I doubt my oversight causes any unsoundness.

Are those targets easy to add to CI?

@UK992
Copy link
Contributor Author

UK992 commented Jul 2, 2018

PR Looking good to me.

@francesca64
Copy link
Member

I'm guessing you'll want a release?

@UK992
Copy link
Contributor Author

UK992 commented Jul 2, 2018

Yes.

@francesca64
Copy link
Member

#587

@UK992
Copy link
Contributor Author

UK992 commented Jul 3, 2018

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened C - in progress Implementation is proceeding smoothly DS - x11
Development

No branches or pull requests

2 participants