Isolate jetty dependencies into a single package #440
Conversation
The servlet and request adapters have moved to the "servlet" package. The only dependency they had on jetty was conditional anyway, so the condition was also modified to not even require jetty on the classpath. See wiremockgh-407. Not a complete modularization yet, but splits up the servlet-only stuff from the jetty server.
|
|
||
| private boolean isPresent(String className) { | ||
| try { | ||
| ClassUtils.getClass(className); |
There was a problem hiding this comment.
Used commons-lang here (it was on the classpath anyway). I guess it could be done without that dependency if needed.
|
As I mentioned on the other thread, this is against master which is frozen currently. Most of the work to isolate Jetty has already been done on the 2.0-beta branch (which is where all the current activity is). |
|
Sorry, I didn't realize. Is this redundant then? |
|
The branch pretty much has these parts covered I think. The Servlet API and Jetty bits are all in their own packages and there's an The config object doesn't expose a setter for the factory yet, so that probably needs to change. I suspect creating another factory impl isn't as simple as it might be either e.g. degrading gracefully when fault injection isn't available, but it should be possible to do it I think. |
|
It looks like the basic outline of the change in this PR could still apply to 2.0-beta (the servlet is not jetty-specific). Maybe I'll re-work it. Need to check my PoC still works with 2.0 first. |
|
See #442 |
The servlet and request adapters have moved to the "servlet" package.
The only dependency they had on jetty was conditional anyway, so
the condition was also modified to not even require jetty on the
classpath.
See gh-407. Not a complete modularization yet, but splits up the
servlet-only stuff from the jetty server.