Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo size #557

Closed
jdegand opened this issue Feb 2, 2024 · 5 comments
Closed

Repo size #557

jdegand opened this issue Feb 2, 2024 · 5 comments
Labels

Comments

@jdegand
Copy link
Contributor

jdegand commented Feb 2, 2024

The size of the repo has doubled in the past few months. I'd suggest you remove rx-angular from dependencies. Unless you have an rx-angular challenge in progess, I'd remove it. rx-angular has 4,000 npm downloads a week. Niche dependencies like @ngrx/signals (7,000 a week) can added per PR. If you remove rx-angular etc, previous PR could break so you'd have to add a warning to the docs when checking out a PR with rx-angular or any removed dependency.

@tomalaforge
Copy link
Owner

Thanks for pointing this out, but does it really matter ? The goal is to try out angular and its ecosystem. If one day, those librairies stop me from uprading, i will remove them, but for now, I don't see any issues with them.
What is your main problem ?

@jdegand
Copy link
Contributor Author

jdegand commented Feb 5, 2024

As someone who always runs out of space, I'd prefer less dependencies especially if they aren't really used.

@tomalaforge
Copy link
Owner

Ok I understand. I still prefer to let them right now, because i like playing around with the library and this repo is kind of a playground where I can test and try new features from all librairies.
But I'll try to avoid adding more lib in the future.

Copy link

This issue is stale because it has been open for 20 days with no activity.

@github-actions github-actions bot added the stale label Feb 28, 2024
@tomalaforge
Copy link
Owner

stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants