-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Handlers Errors #33
Comments
G'day @1995parham, would you be able to describe better the issue you're having? Currently your request is a little vague. |
Sure, for example on gofiber we have: app.Get("/", func(c *fiber.Ctx) error {
return c.SendString("Hello, World 👋!")
}) I think, it doesn't a good idea to wrap its error. |
You should already be able to have wrapcheck refrain from reporting errors like this using the configuration parameters. Is that not working for you? |
Yes, exactly we are using that configuration. The only issue is about for us to repeat the default values too. So if we can somehow add these into the defaults or append the configuration to them it would be great. |
I'm sorry, I don't think it makes sense to add these to the default configuration, as this practice wouldn't be scalable for all the libraries out there. Yes, you need to add the defaults yourself if you are going to configure it. This enables people to easily override the default set. |
Most of the go http frameworks has the error as return in their handlers, so we can add them into the ignore pattern if you agree.
The text was updated successfully, but these errors were encountered: