Dialyzer issues for required fields

[sargun]

When the codegen goes over required fields, it generates code like:

'merge_msg_mesos_state_agentoverlayinfo.state'(#'mesos_state_agentoverlayinfo.state'{status
                       =
                       PFstatus,
                         error
                       =
                       PFerror},
                 #'mesos_state_agentoverlayinfo.state'{status
                       =
                       NFstatus,
                         error
                       =
                       NFerror},
                 _) ->
    #'mesos_state_agentoverlayinfo.state'{status =
                if NFstatus =:= undefined ->
                 PFstatus;
             true -> NFstatus
                end,
            error =
                if NFerror =:= undefined ->
                 PFerror;
             true -> NFerror
                end}.

The generated typespec for status / NFstatus doesn't include undefined. Given this, if NFstatus =:= undefined should never match. I think that the codegen should omit that if the field is required in the merge function.

[tomas-abrahamsson]

Agree this looks wrong, will take a look.

[tomas-abrahamsson]

I just pushed 3.26.3, which fixes this issue (hence closing) Thanks for reporting!