-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional locations #58
Comments
Okay, this looks like a good idea. I just have to think, where to put the parsing code? Do you think, it would be more meaningful to put it in a complex loop to |
Had some trouble rebasing the my branch. My initial thought was that yet another class would be a bit of an overkill but after trying to implement this it might be better to have a This first suggestion is how I personally would do it, a function returning a dict is ok since it doesn't need any persistent state stored in A separate class might be the best solution? |
First of all, please unify the naming. I think Yes, the function returning a dict is a good solution, but current code location is really unfortunate. I would prefer creating a new class ( |
Ok, I'll look into it during the weekend. |
I've done the changes you suggested and changed Should I add a str and repr to the class or is it ok to have a "bare bones" class? Test aren't included yet. |
It looks good. Just a few more things:
|
I have just merged #59 and will release the features in version 3.5. Thank you Åke and happy easter to you too! |
Some caches provides a list of additional waypoints (GC58QHM, GCMNF7).
The additional waypoints are commonly used for adding coordinates for Parking areas, steps in multi caches and similar things.
The additional waypoints list contains the following columns for each waypoint
My suggestion is that a light object is created (perhaps a
namedtuple
) with at least Type, Lookup, Name, Coordinate and Note fields.Either the list is converted to a dict with the Lookup (name is not unique) as key or as a plain list.
I will submit a pull request referencing this issue with a simple implementation.
The text was updated successfully, but these errors were encountered: