-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pause indicator in controls doesn't always work #578
Comments
have no idea what happened on your side. I cannot reproduce it here. |
I'm talking about the fact that if you add a play / pause button to the control panel, then its display in half of the cases will be incorrect if you keep the interface open while pressing the space key. This happens even with |
As I said, cannot reproduce.
Shouldn't be reported to mpv instead? |
I also can't replicate. I thought first that there might not be a call to request re-render in property listeners created by control buttons, but there is. Could it be related to mpv-player/mpv#8350? It was an issue where requesting UI renders during pause events was not working, which was fixed recently. So maybe try updating mpv. If that's not the issue, then I'm out of ideas atm. |
Yes! With |
Do I need to write an issue to the mpv repository? This is a problem on their part. Despite its 'cloes' status, it is still present in mpv after several versions. |
If you're using the latest released version, then you don't have the fix yet. |
OK. For a long time they solved this problem, which was mentioned back in 2020. I'll wait. The uosc developer obviously won't help me with this. |
I added to
uosc.conf
, in thecontrols=
line, thecycle:play_arrow:pause:no=pause/yes=play_arrow?play/pause
element. It allows me to visually verify whether the video is paused or not. But sometimes when I press the space key with the controls pane open, the pause indicator stays in its previous, outdated state.I noticed that if you move the mouse cursor up a little bit, then the element is updated from the wrong state to the correct one. At the same time, if you move the mouse close, then the interface elements will not change in any way. The
proximity
option is responsible for this. I tried to edit the code, but I couldn't achieve the same neat result.The text was updated successfully, but these errors were encountered: